Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI issues #3716

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Minor UI issues #3716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccc79b0
Fix overflow on transaction activity details
xpaczka Dec 20, 2023
db2728b
Center loading spinner
xpaczka Dec 20, 2023
775a42a
Make filters slide up full height
xpaczka Dec 20, 2023
baa01ac
Adjust error message position
xpaczka Dec 20, 2023
bcfa580
Merge branch 'main' into minor-issues
jagodarybacka Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/components/NFTs/Filters/NFTsFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export default function NFTsFilters(): ReactElement {
display: flex;
flex-direction: column;
gap: 16px;
height: 456px;
height: 471px;
overflow-y: scroll;
padding: 0 24px 8px;
}
Expand Down
3 changes: 2 additions & 1 deletion ui/components/Shared/SharedAddress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import classNames from "classnames"
import React, { ReactElement, useCallback } from "react"
import { useBackgroundDispatch } from "../../hooks"
import SharedTooltip from "./SharedTooltip"
import { trimWithEllipsis } from "../../utils/textUtils"

type SharedAddressProps = {
address: string
Expand Down Expand Up @@ -53,7 +54,7 @@ export default function SharedAddress({
className={classNames({ ellipsis: elide })}
>
<p className={classNames({ ellipsis: elide })}>
{primaryText}
{trimWithEllipsis(primaryText, 15)}
{name !== undefined && nameResolverSystem !== undefined && (
<>
<SharedTooltip width={130}>
Expand Down
6 changes: 6 additions & 0 deletions ui/components/Shared/SharedButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,12 @@ export default function SharedButton(
.unstyled {
unset: all;
}
.spinner_wrap {
width: 100%;
height: 100%;
display: grid;
place-items: center;
}
`}
</style>
</button>
Expand Down
2 changes: 1 addition & 1 deletion ui/components/Shared/SharedInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export function SharedTypedInput<T = string>(props: Props<T>): ReactElement {
font-weight: 500;
font-size: 14px;
line-height: 20px;
margin-top: 3px;
margin-top: ${label ? "3px" : "53px"};
margin-left: 5px;
}
.warning {
Expand Down
2 changes: 1 addition & 1 deletion ui/pages/Abilities/AbilityFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export default function AbilityFilter(): ReactElement {
display: flex;
flex-direction: column;
gap: 24px;
height: 456px;
height: 471px;
overflow-y: scroll;
padding: 0 24px 8px;
}
Expand Down
Loading