Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Goerli testnet from the testnets list #3718

Merged
merged 3 commits into from
May 4, 2024
Merged

Conversation

michalinacienciala
Copy link
Contributor

@michalinacienciala michalinacienciala commented Dec 22, 2023

Each Ethereum testnet has a limited lifespan. With end of 2023 Goerli testnet becomes deprecated. As it's one of the testnets we have set as a default testnet, we will no longer want to show it after that date. The remaining default testnets will be Ethereum Sepolia and Arbitrum Sepolia. Other testnets can be added by users manually (no changes in that area).

⚠️ Marked as draft until 2024 (but ready for review)
⚠️ This PR does not change e2e tests - this will be done in a separate PR (so until that PR gets merged to this one, the tests here may fail)

Tests:

  • enable testnets and verify that Goerli is no longer available on the testnets list
  • import Goerli manually (if still present on the Chainlist) and make sure swaps are not supported for it (and it resembles other manually added networks)

Latest build: extension-builds-3718 (as of Sat, 13 Apr 2024 20:27:14 GMT).

Each Ethereum testnet has a limited lifespan. With end of 2023 Goerli testnet
becomes deprecated. As it's one of the testnets we have set as a default
testnet, we will no longer want to show it after that date.
The remaining default testnets will be Ethereum Sepolia and Arbitrum Sepolia.
Other tesnets can be added by users manually (no changes in that area).
@michalinacienciala michalinacienciala self-assigned this Dec 22, 2023
@michalinacienciala michalinacienciala requested a review from a team December 22, 2023 14:08
As Goerli got removed from the list of default testnets, we need to update the
tests that assert the number of supported networks.
@Shadowfiend Shadowfiend marked this pull request as ready for review May 4, 2024 21:28
Copy link
Contributor

@Shadowfiend Shadowfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@Shadowfiend Shadowfiend merged commit 25e2a72 into main May 4, 2024
6 checks passed
@Shadowfiend Shadowfiend deleted the remove-goerli-support branch May 4, 2024 21:28
@Shadowfiend Shadowfiend mentioned this pull request Jul 15, 2024
Shadowfiend added a commit that referenced this pull request Oct 5, 2024
## What's Changed
* v0.57.0 by @Shadowfiend in
#3735
* Support for Wallet Test Framework by @SamWilsn in
#3737
* Fix typos by @omahs in
#3724
* Fix a couple of typos from contribution by @Shadowfiend in
#3742
* Move action using node12 to a newer version by @michalinacienciala in
#3722
* Changed the build for the firefox browser by @kogeletey in
#3733
* Remove Goerli testnet from the testnets list by @michalinacienciala in
#3718
* Move autolock timer by @radchukd in
#3743
* Tweaks and creaks: Disable UNS, fix Ledger signing on built-in
non-ETH/MATIC networks by @Shadowfiend in
#3746

## New Contributors
* @SamWilsn made their first contribution in
#3737
* @kogeletey made their first contribution in
#3733
* @radchukd made their first contribution in
#3743

Latest build:
[extension-builds-3747](https://github.com/tahowallet/extension/suites/26032567144/artifacts/1703810792)
(as of Mon, 15 Jul 2024 21:35:33 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants