Merge Main into branch-A-CodeQuality #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were no assertions in the Commands that were being implemented in dude. Especially the constructors, where many of the constructions were assuming certain conditions to hold true. Conditions that the command class sub-class constructors assumed to be true: * String input : Assumed to be not null, assumed to contain appropriate command * Tasklist tasklist: Assumed to be not null Now assertions have been added to the constructors to make sure such conditions are actually holding true. These assertions will help to reduce bugs making sure the conditions assumed to be true, actually hold true. I believe this will drastically reduce bugs when I decide to add on more features.
adding assertions to main code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.