[Opt] Constant folding for BitExtractStmt #1307
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1307 +/- ##
==========================================
+ Coverage 66.16% 66.68% +0.52%
==========================================
Files 36 36
Lines 5077 5094 +17
Branches 934 931 -3
==========================================
+ Hits 3359 3397 +38
+ Misses 1554 1539 -15
+ Partials 164 158 -6
Continue to review full report at Codecov.
|
taichi/transforms/constant_fold.cpp
Outdated
| result = (input->val[0].val_int() >> stmt->bit_begin) & | ||
| ((1LL << (stmt->bit_end - stmt->bit_begin)) - 1); | ||
| } else { | ||
| result = (input->val[0].val_uint() >> stmt->bit_begin) & | ||
| ((1LL << (stmt->bit_end - stmt->bit_begin)) - 1); |
There was a problem hiding this comment.
I thought BitExtractStmt is only used for i32?
There was a problem hiding this comment.
We probably need to support unsigned inputs as well :-)
| if (!input) | ||
| return; |
There was a problem hiding this comment.
| if (!input) | |
| return; | |
| if (!input || input->element_type() == DataType::i32) | |
| return; |
There was a problem hiding this comment.
Why not do constant folding when the input is i32?
taichi/transforms/constant_fold.cpp
Outdated
| result = (input->val[0].val_int() >> stmt->bit_begin) & | ||
| ((1LL << (stmt->bit_end - stmt->bit_begin)) - 1); | ||
| } else { | ||
| result = (input->val[0].val_uint() >> stmt->bit_begin) & | ||
| ((1LL << (stmt->bit_end - stmt->bit_begin)) - 1); |
There was a problem hiding this comment.
We probably need to support unsigned inputs as well :-)
taichi/transforms/constant_fold.cpp
Outdated
| auto result_stmt = Stmt::make<ConstStmt>( | ||
| LaneAttribute<TypedConstant>(TypedConstant(DataType::i32, result))); |
There was a problem hiding this comment.
Given the part before already uses uint and int which covers all integral types, here maybe we should support all integral types as well? Just change DataType::i32 into the input data type.
There was a problem hiding this comment.
Or we may need an assertion on input_type != DataType::i8 && input_type != DataType::i16?
There was a problem hiding this comment.
Given the part before already uses
uintandintwhich covers all integral types, here maybe we should support all integral types as well? Just changeDataType::i32into the input data type.
The typecheck pass set ret_type = i32 for OffsetAndExtractBitsStmt. Shall we also change it to the input data type?
There was a problem hiding this comment.
Or we may need an assertion on
input_type != DataType::i8 && input_type != DataType::i16?
I think this is OK -- if the input is representable by i8, so is the output.
* [Opt] Constant folding for BitExtractStmt * fix tests * Let BitExtractStmt support all integral types
Related issue = #656 #510 close #1278
[Click here for the format server]