Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Opt] [bug] Better aliasing analysis for dead store elimination #1432

Merged
merged 2 commits into from
Jul 7, 2020
Merged

[Opt] [bug] Better aliasing analysis for dead store elimination #1432

merged 2 commits into from
Jul 7, 2020

Conversation

xumingkuan
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited
Loading

Codecov Report

Merging #1432 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1432   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files          38       38           
  Lines        5264     5264           
  Branches      944      944           
=======================================
  Hits         3499     3499           
  Misses       1603     1603           
  Partials      162      162

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75e5ed...3f13180. Read the comment docs.

yuanming-hu
yuanming-hu approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks.

(Maybe it makes sense to introduce in the future a three-state enum with {true, uncertain, false} so that you can unify maybe/definitely_same_address/contain).

@xumingkuan xumingkuan merged commit 8f5c84d into taichi-dev:master Jul 7, 2020
@FantasyVR FantasyVR mentioned this pull request Jul 8, 2020
Merged
@xumingkuan xumingkuan mentioned this pull request Jul 9, 2020
Merged
@xumingkuan xumingkuan deleted the cfg2 branch July 11, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

@taichi-gardener taichi-gardener Awaiting requested review from taichi-gardener

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xumingkuan @yuanming-hu @taichi-gardener