-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] [misc] Use sys.getfilesystemencoding() to prevent possible locale errors #1775
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1775 +/- ##
==========================================
+ Coverage 42.60% 42.66% +0.05%
==========================================
Files 44 44
Lines 6182 6174 -8
Branches 1071 1074 +3
==========================================
Hits 2634 2634
+ Misses 3394 3385 -9
- Partials 154 155 +1
Continue to review full report at Codecov.
|
b2be201
to
6933156
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would you help me confirm this works on OS X for all locale combinations?
I actually tried. My locale
looks the same as taichi-dev/taichi_three#13 (comment), but I don't have this problem. Do you know how I can repro this?
I'm not sure, what's your MacOS and Python version? And the one in taichi_three#13? |
Locales are always international packages' headache yet no way to test against them at the time being. Let's try to merge this in given that CI passed and we used enough try-except's here and hopefully it can solve the hidden locale problems :)
Actually are you testing in |
Related issue = taichi-dev/taichi_three#13 #428
See https://www.python.org/dev/peps/pep-0529/#update-sys-getfilesystemencoding.
[Click here for the format server]
@k-ye Would you help me confirm this works on OS X for all
locale
combinations?