-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Expand the tolerance for testing on metal backend #1779
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1779 +/- ##
==========================================
- Coverage 43.59% 42.66% -0.94%
==========================================
Files 44 44
Lines 5968 6174 +206
Branches 1074 1075 +1
==========================================
+ Hits 2602 2634 +32
- Misses 3212 3384 +172
- Partials 154 156 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this is great! Sorry it just occurred to me, but could you try running with fast_math=False
(without changes in this PR)?
Thanks for the reply!
And this test can still be wrong if I didn't expand the approx in
Can I do more tests for you? Maybe this problem shouldn't be ignored in this way easily ;) |
I see.
No that's the only thing i could think of... Thanks!
Yeah, but given it didn't fail on my side, I'm attributing this to hardware differences.. ;-( |
Related issue = Close #1679
As @archibate adviced, I expand the approx value on metal platform.
Now
test_ad_basic.py
can work properly on my machine![Click here for the format server]