Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add path to Python executable to 'ti diagnose' #1801

Merged
merged 2 commits into from
Aug 29, 2020

Conversation

chengluyu
Copy link
Contributor

@chengluyu chengluyu commented Aug 28, 2020

Related issue = closes #1792

[Click here for the format server]


This PR adds Python executable path to ti diagnose, as mention in #1792.

There is another change: I found that running ti diagnose in development mode will cause syntax errors on macOS because python still refers to Python 2.7.16, and current executable will always be the correct one with Taichi installed. So I replaced 'python' with the executable path.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! LGTM. Welcome to the Taichi developer community!

I'll merge this once CI passes. Thank you for contributing!

@yuanming-hu
Copy link
Member

Btw, could you run ti format to enforce code format? Usually @taichi-gardener will help you enforce code format, but it seems that it doesn't have access to FrokYard :-)

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1801 into master will increase coverage by 2.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1801      +/-   ##
==========================================
+ Coverage   61.74%   64.02%   +2.28%     
==========================================
  Files          19       19              
  Lines        3850     3678     -172     
  Branches      691      693       +2     
==========================================
- Hits         2377     2355      -22     
+ Misses       1348     1197     -151     
- Partials      125      126       +1     
Impacted Files Coverage Δ
python/taichi/lang/ast_checker.py 70.58% <0.00%> (-1.64%) ⬇️
python/taichi/lang/linalg.py 89.33% <0.00%> (-0.67%) ⬇️
python/taichi/lang/meta.py 62.31% <0.00%> (-0.54%) ⬇️
python/taichi/lang/__init__.py 41.94% <0.00%> (-0.51%) ⬇️
python/taichi/lang/shell.py 0.00% <0.00%> (ø)
python/taichi/lang/kernel.py 71.17% <0.00%> (+0.13%) ⬆️
python/taichi/lang/util.py 31.73% <0.00%> (+0.37%) ⬆️
python/taichi/lang/transformer.py 81.61% <0.00%> (+0.68%) ⬆️
python/taichi/lang/impl.py 66.37% <0.00%> (+1.87%) ⬆️
python/taichi/lang/snode.py 68.42% <0.00%> (+4.19%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da41c85...d5cc9f5. Read the comment docs.

@chengluyu
Copy link
Contributor Author

Hi, I've run ti format (and found another tiny bug and sent a PR #1802). :)

@yuanming-hu yuanming-hu merged commit 67dd966 into taichi-dev:master Aug 29, 2020
@yuanming-hu yuanming-hu mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI] Add Python executable path to "ti diagnose"
2 participants