[misc] Revert "Better error message when vector used as if's condition variable" (#1804) #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
changed the title
archibate
added a commit
that referenced
this pull request
Aug 31, 2020
…able (#1804)" (#1810) * Revert "[misc] Revert "Better error message when vector used as if's condition variable (#1804)" (#1808)" This reverts commit b5c3ee2. * revert __abs__ to fix test * [skip ci] Apply suggestions from code review Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com> * [skip ci] Update docs/arithmetics.rst Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com> Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1804.
I opened #1809 to prevent similar issues from happening again :-)