[opt] Simplify replace_statements and improve demote_dense_struct_fors #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-ye
approved these changes
May 13, 2021
taichi/ir/transforms.h
Outdated
| bool transform_statements( | ||
| IRNode *root, | ||
| std::function<bool(Stmt *)> filter, | ||
| std::function<void(Stmt *, DelayedIRModifier *)> transformer); | ||
| /** | ||
| * @param root The IR root to be traversed. | ||
| * @param filter A function which tells if a statement need to be replaced. | ||
| * @param generator If a statement s need to be replaced, generate a new | ||
| * statement s1 with the argument s, insert s1 to s's place, and replace all |
There was a problem hiding this comment.
nit: by saying "insert s1 to s's place", do we mean "insert |s1| to where |s| is defined, removes |s|'s definition and replaces all usages of ..."?
There was a problem hiding this comment.
Right, I'll rephrase this.
| bool replace_statements_with(IRNode *root, | ||
| std::function<bool(Stmt *)> filter, | ||
| std::function<Stmt *(Stmt *)> generator); | ||
| bool replace_statements(IRNode *root, |
There was a problem hiding this comment.
Following the above comment, how is |s|'s defining stmt handled in this case?
There was a problem hiding this comment.
|s|'s defining stmt is erased here.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1989 -- This PR provides a filtered map operation on the IR. We can replace some
gather_statementsusages withtransform_statementsor something similar.A continuation of #2306.
Also reduces the time complexity of demote_dense_struct_fors from O(snodes.size() * (physical_indices.size() + N)) to O(snodes.size() * physical_indices.size() + N) where N is the total number of statements in the IR.
[Click here for the format server]