Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reproduction for Nx bug (it installs deps with legacy-peer-deps=true) #1337

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Jun 25, 2024

Getting started

nvm use 18
npm ci

Pay attention that project does NOT use legacy-peer-deps!

Case 1

Run the following command

nx migrate --run-migrations

it will logs:

 NX   Running 'npm install' to make sure necessary packages are installed

removed 297 packages, and audited 2714 packages in 4s

and then it will throw error:

Cannot find module 'ts-morph'

Case 2

Reset all environment (revert package-lock.json changes and run again npm ci).

Then run the following command:

npm_config_legacy_peer_deps=false nx migrate --run-migrations

it will log

up to date, audited 3008 packages in 3s

And then migrations will be executed successfully! No error.

Copy link
Contributor

⛔ Firebase job has failed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant