-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(addon-mobile): SwipeActions
fix actions in IOS safari
#10163
Conversation
Failed tests ❌Before (main) ← Diff → After (local)tests-demo-demo.pw-Demo-components-swipe-actions-chromium-retry2/components-swipe-actions/1.diff.png(updated for commit 05d7fc6) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10163 +/- ##
==========================================
- Coverage 65.90% 65.84% -0.07%
==========================================
Files 1229 1233 +4
Lines 16041 16092 +51
Branches 2343 2310 -33
==========================================
+ Hits 10572 10595 +23
- Misses 5268 5304 +36
+ Partials 201 193 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Visit the preview URL for this PR (updated for commit 05d7fc6): https://taiga-previews-demo--pr10163-swipe-action-fix-demo-gc0ngmyo.web.app (expires Wed, 15 Jan 2025 08:42:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
BundleMonUnchanged files (5)
Total files change +8B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Playwright test results 2 failed Details Open report ↗︎ Failed testschromium › tests/demo/demo.pw.spec.ts › Demo › /components/swipe-actions Skipped testswebkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation |
Fixes #10152