Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-doc): pin "ngx-highlightjs" peer dependency version #10170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hakimio
Copy link
Contributor

@hakimio hakimio commented Jan 14, 2025

Fixes #10106

@hakimio hakimio requested a review from a team as a code owner January 14, 2025 14:01
@hakimio hakimio requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team January 14, 2025 14:01
Copy link

lumberjack-bot bot commented Jan 14, 2025

Tests completed successfully ✅

Good job 🔥

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.84%. Comparing base (ef907c4) to head (c21dadb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10170   +/-   ##
=======================================
  Coverage   65.84%   65.84%           
=======================================
  Files        1233     1233           
  Lines       16092    16092           
  Branches     2338     2339    +1     
=======================================
  Hits        10595    10595           
+ Misses       5266     5233   -33     
- Partials      231      264   +33     
Flag Coverage Δ
summary 65.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Jan 14, 2025

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
308.3KB +10%
demo/browser/vendor.(hash).js
260.27KB +10%
demo/browser/runtime.(hash).js
44.94KB +10%
demo/browser/styles.(hash).css
20.27KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.62MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the fix-ngx-highlightjs-version branch from e8fbf66 to c21dadb Compare January 14, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - tui-doc-code is not compatible with the latest version of ngx-highlightjs
2 participants