Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @taiga-ui/icons-fontawesome #8493

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

splincode
Copy link
Member

image

Copy link

lumberjack-bot bot commented Aug 13, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@waterplea
Copy link
Collaborator

Let's use two words everywhere - Font Awesome. Not sure about package name. Variants:

  • @taiga-ui/icons-fontawesome
  • @taiga-ui/icons-font-awesome
  • @taiga-ui/icons-awesome

What do you guys think, @vladimirpotekhin @nsbarsukov @mdlufy ?

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Visit the preview URL for this PR (updated for commit 40ad48e):

https://taiga-previews--pr8493-splincode-feat-aweso-yhlxjn81.web.app

(expires Wed, 14 Aug 2024 09:28:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Aug 13, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
278.27KB (+74B +0.03%) +10%
demo/browser/runtime.(hash).js
41.32KB (+40B +0.09%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
216.27KB +10%
demo/browser/styles.(hash).css
11.56KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +114B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.74MB (+38.75KB +0.56%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the splincode/feat-awesome branch from fe5b297 to 40ad48e Compare August 13, 2024 09:27
@waterplea waterplea merged commit 131b3ed into main Aug 13, 2024
28 of 29 checks passed
@waterplea waterplea deleted the splincode/feat-awesome branch August 13, 2024 14:27
This was referenced Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants