Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(demo): update Textfield + Maskito example #9693

Merged
merged 3 commits into from
Nov 6, 2024
Merged

chore(demo): update Textfield + Maskito example #9693

merged 3 commits into from
Nov 6, 2024

Conversation

nsbarsukov
Copy link
Member

Fixes #9679

@nsbarsukov nsbarsukov self-assigned this Nov 5, 2024
@nsbarsukov nsbarsukov requested a review from a team as a code owner November 5, 2024 15:18
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team November 5, 2024 15:18
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 5, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 9bebcd7):

https://taiga-previews--pr9693-textfield-mask-y247xbre.web.app

(expires Thu, 07 Nov 2024 09:22:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 5, 2024 •
edited
Loading

BundleMon

Files updated (2)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 260.04KB (+20B +0.01%) +10%
✅ demo/browser/runtime.(hash).js
 43.45KB (-29B -0.07%) +10%
Unchanged files (3)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 298.92KB +10%
✅ demo/browser/styles.(hash).css
 19.58KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change -9B 0%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.24MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@waterplea
Copy link
Collaborator

Custom cleaner doesn't seem to work

@nsbarsukov
Copy link
Member Author

Custom cleaner doesn't seem to work

🤔

2024-11-05.18.57.56.mov

splincode
splincode reviewed Nov 5, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@nsbarsukov nsbarsukov requested a review from splincode November 6, 2024 09:27
@waterplea waterplea merged commit 7d3a750 into main Nov 6, 2024
26 of 27 checks passed
@waterplea waterplea deleted the textfield-mask branch November 6, 2024 10:05
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
@nsbarsukov @shiv9604
chore(demo): update Textfield + Maskito example (taiga-family#9693)
c569ae3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@nsbarsukov nsbarsukov

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - value in the input is overlapped by a tuiTextfieldPrefix when scrolling
3 participants
@nsbarsukov @waterplea @splincode