Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in validations_test.go #59

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Conversation

zahiar
Copy link
Collaborator

@zahiar zahiar commented Aug 16, 2021

Dependencies

No

What Is Changing

Fix typo in validations_test.go
Incorrect method was being called, i.e. not the one we are testing.

Test Steps

$ make test
go test -cover ./...
?       github.com/taiidani/terraform-provider-jenkins  [no test files]
ok      github.com/taiidani/terraform-provider-jenkins/jenkins  (cached)        coverage: 18.8% of statements

Incorrect method was being called, i.e. not the one we are testing.
@zahiar zahiar added this to the 0.9 milestone Aug 16, 2021
@zahiar zahiar requested a review from taiidani August 16, 2021 18:15
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #59 (be10bc0) into main (bf7747c) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   81.44%   81.60%   +0.15%     
==========================================
  Files          17       17              
  Lines        1261     1261              
==========================================
+ Hits         1027     1029       +2     
+ Misses        184      183       -1     
+ Partials       50       49       -1     
Flag Coverage Δ
acceptance 81.60% <ø> (+0.15%) ⬆️
unit 53.76% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jenkins/validations.go 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7747c...be10bc0. Read the comment docs.

@zahiar zahiar added the bug Something isn't working label Aug 16, 2021
Copy link
Owner

@taiidani taiidani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@taiidani taiidani merged commit 3730a01 into taiidani:main Aug 21, 2021
@zahiar zahiar deleted the fix-test-typo branch August 21, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants