Added support the [cargo-new] table
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
requested changes
Aug 31, 2024
src/de.rs
Outdated
| pub vcs: Option<Value<VersionControlSoftware>>, | ||
| } | ||
|
|
||
| #[allow(clippy::exhaustive_enums)] |
There was a problem hiding this comment.
I think this enum should use #[non_exhaustive].
There was a problem hiding this comment.
Thanks, good catch. I made this #[non_exhaustive] and reexported it at the crate root to match the other enums 👍
tests/test.rs
Outdated
| @@ -72,7 +72,7 @@ fn assert_reference_example(de: fn(&Path, ResolveOptions) -> Result<Config>) -> | |||
| assert_eq!(config.future_incompat_report.frequency, Some(Frequency::Always)); | |||
|
|
|||
| // TODO | |||
| // [cargo-new] | |||
| assert_eq!(config.cargo_new.vcs, None); | |||
There was a problem hiding this comment.
We can test this by uncommenting the following two lines:
cargo-config2/tests/fixtures/reference/.cargo/config.toml
Lines 41 to 42 in bb273c0
taiki-e
reviewed
Sep 1, 2024
taiki-e
approved these changes
Sep 1, 2024
|
Published in 0.1.28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! 👋
I also added support for the
cargo-newtable which only has 1 none deprecated property.I did not add the deprecated fields.