Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document --profile --cargo-profile --config-path #270

Closed
wants to merge 4 commits into from

Conversation

TriplEight
Copy link

cc #267
cc #269

@taiki-e
Copy link
Owner

taiki-e commented Apr 29, 2023

We have intentionally not documented nextest-specific options; as the help message states, you can refer to them using cargo nextest run --help.

[NEXTEST_OPTIONS] Options for cargo-nextest; For more information try `cargo nextest run --help`

The reasons are the same as those stated in #267 (comment).

This design eliminates the need to respond to each addition or deletion of CLI flags and also makes it easier to maintain compatibility with older cargo-nextest.

Also what you are editing is a help message for subcommands unrelated to nextest.

@TriplEight
Copy link
Author

We have intentionally not documented nextest-specific options; as the help message states, you can refer to them using cargo nextest run --help.

Thanks for the clarification, I understand. But there's a certain confusion in cargo native and nextest --profile and --cargo-profile flags. I wanted to address it.

@TriplEight
Copy link
Author

Maybe it makes sense to have a "supported nextest flags" category,
as per #267 (comment)

cargo-llvm-cov doesn't parse all the cargo-nextest CLI flags, but only those necessary for cargo-llvm-cov to work properly, and just passthrough everything else to the cargo-nextest.

@taiki-e
Copy link
Owner

taiki-e commented Apr 29, 2023

as per #267 (comment)

cargo-llvm-cov doesn't parse all the cargo-nextest CLI flags, but only those necessary for cargo-llvm-cov to work properly, and just passthrough everything else to the cargo-nextest.

What I mentioned there relates to flags that do not work unless the cargo-llvm-cov also recognizes them, and there are in fact many flags that work just fine even if the cargo-llvm-cov does not recognize them.

It would be great if someone could exhaustively test for compatibility with cargo-nextest options, document and issue warnings about options that don't work, but that would require a lot of work.

@taiki-e
Copy link
Owner

taiki-e commented Aug 6, 2023

Closing in favor of #271. Thanks anyway for the PR.

@taiki-e taiki-e closed this Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants