Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --direct flag to use -Z direct-minimal-versions instead of -Z minimal-versions #25

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Oct 27, 2023

If there are dependencies that are incompatible with -Z minimum-versions, it is also reasonable to use -Z direct-minimal-versions, since it is hard to maintain -Z minimum-versions compatibility in such situations.

By using --direct flag, cargo-minimal-versions uses -Z direct-minimal-versions instead of -Z minimal-versions.

cargo minimal-versions check --direct

Note that using -Z direct-minimal-versions may miss some of the problems that can be found when using -Z minimal-versions. However, if there is a problem only in a particular version of a dependency, a problem that was missed when using -Z minimal-versions may be found by using -Z direct-minimal-versions (because the resolved dependency version is different).

Closes #16
cc rust-lang/cargo#5657

@taiki-e taiki-e force-pushed the direct branch 3 times, most recently from 1f7944f to 8bddb02 Compare October 27, 2023 15:02
@taiki-e taiki-e merged commit 1126ebb into main Oct 27, 2023
21 checks passed
@taiki-e taiki-e deleted the direct branch October 27, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support -Zdirect-minimal-versions
1 participant