Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile failure with non-cargo build systems #23

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Fix compile failure with non-cargo build systems #23

merged 1 commit into from
Aug 25, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Aug 25, 2020

Fixes #22

taiki-e
taiki-e commented Aug 25, 2020
View reviewed changes
build.rs
@@ -1,6 +1,8 @@
use std::{env, fs, path::PathBuf};

fn main() {
println!("cargo:rustc-cfg=const_fn_has_build_script");
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is like a marker that means "build-script was run". If the build-script was run, but the output of the build-script is broken, you should get an error.

@taiki-e
Copy link
Owner Author

taiki-e commented Aug 25, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 25, 2020

Build succeeded:

@bors bors bot merged commit d0d679f into master Aug 25, 2020
@bors bors bot deleted the build-script branch August 25, 2020 15:36
@taiki-e taiki-e mentioned this pull request Sep 9, 2020
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile failure with non-cargo build systems
1 participant
@taiki-e