Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syft tool #135

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Add syft tool #135

merged 1 commit into from
Jun 10, 2023

Conversation

FirelightFlagboy
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy commented Jun 9, 2023 •
edited
Loading

Closes #131

FirelightFlagboy added a commit to FirelightFlagboy/install-action that referenced this pull request Jun 9, 2023
@FirelightFlagboy
Add syft tool
73a4262 
Closes taiki-e#135
@FirelightFlagboy FirelightFlagboy force-pushed the add-syft branch 2 times, most recently from 73a4262 to a226d97 Compare June 9, 2023 17:07
taiki-e
taiki-e requested changes Jun 9, 2023
View reviewed changes
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add syft to the table in "Supported tools" section in README.md? (like this)

.github/workflows/ci.yml Show resolved Hide resolved
tools/codegen/base/syft.json Outdated Show resolved Hide resolved
@FirelightFlagboy FirelightFlagboy requested a review from taiki-e June 10, 2023 09:25
@taiki-e
Copy link
Owner

taiki-e commented Jun 10, 2023

LGTM. Could you add syft to the table in "Supported tools" section in README.md? (like this)

@FirelightFlagboy
Copy link
Contributor Author

Yes, I forgot

taiki-e
taiki-e approved these changes Jun 10, 2023
View reviewed changes
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 9ead256 into taiki-e:main Jun 10, 2023
@taiki-e
Copy link
Owner

taiki-e commented Jun 10, 2023

Published in 2.10.0.

@FirelightFlagboy FirelightFlagboy deleted the add-syft branch June 10, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I would like to add support for the tool syft
2 participants
@FirelightFlagboy @taiki-e