Ensure that users cannot implement PinnedDrop without proper attr
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes taiki-e#179 Previously, it was possible to provide a `#[pinned_drop]` implementation without annotating the pin-projected type with `#[pin_project(PinnedDrop)]`. This would result in the `PinnedDrop` impl never being used, without any warnings or errors being emitted to the user. This commit makes us generate a dummy `PinnedDrop` impl if the user does not pass `PinnedDrop` as an argument to `#[pin_project]`. This dummy impl will conflict with any user-provided impl, ensuring that the user cannot accidentally a non-functional `PinnedDrop` impl.
Aaron1011
commented
Jan 25, 2020
| @@ -0,0 +1,8 @@ | |||
| error[E0119]: conflicting implementations of trait `pin_project::__private::PinnedDrop` for type `Foo`: | |||
There was a problem hiding this comment.
This isn't the greatest error message, but I don't see any way of improving it.
|
Looks good, thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 27, 2020
180: Ensure that users cannot implement `PinnedDrop` without proper attr r=taiki-e a=Aaron1011 Fixes #179 Previously, it was possible to provide a `#[pinned_drop]` implementation without annotating the pin-projected type with `#[pin_project(PinnedDrop)]`. This would result in the `PinnedDrop` impl never being used, without any warnings or errors being emitted to the user. This commit makes us generate a dummy `PinnedDrop` impl if the user does not pass `PinnedDrop` as an argument to `#[pin_project]`. This dummy impl will conflict with any user-provided impl, ensuring that the user cannot accidentally a non-functional `PinnedDrop` impl. Co-authored-by: Aaron Hill <aa1ronham@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
Previously, it was possible to provide a
#[pinned_drop]implementationwithout annotating the pin-projected type with
#[pin_project(PinnedDrop)]. This would result in thePinnedDropimplnever being used, without any warnings or errors being emitted to the
user.
This commit makes us generate a dummy
PinnedDropimpl if the user doesnot pass
PinnedDropas an argument to#[pin_project]. This dummyimpl will conflict with any user-provided impl, ensuring that the user
cannot accidentally a non-functional
PinnedDropimpl.