Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle where clauses on tuple structs #186

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Properly handle where clauses on tuple structs #186

merged 1 commit into from
Apr 11, 2020

Conversation

Aaron1011
Copy link
Collaborator

Previously, we were generating the where clause in the wrong position
for the generated projection struct, leading to a compilation error.

@Aaron1011 Aaron1011 requested a review from taiki-e as a code owner April 11, 2020 06:18
@Aaron1011 Aaron1011 force-pushed the fix/tuple-where-clause branch from be19c28 to fa09b09 Compare April 11, 2020 07:07
@Aaron1011
Copy link
Collaborator Author

This appears to have hit rust-lang/rust#70814.

@Aaron1011
Properly handle where clauses on tuple structs
9bf1917 
Previously, we were generating the `where` clause in the wrong position
for the generated projection struct, leading to a compilation error.
@Aaron1011 Aaron1011 force-pushed the fix/tuple-where-clause branch from fa09b09 to 9bf1917 Compare April 11, 2020 07:09
taiki-e
taiki-e approved these changes Apr 11, 2020
View reviewed changes
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me.

@taiki-e
Copy link
Owner

taiki-e commented Apr 11, 2020

This appears to have hit rust-lang/rust#70814.

Yeah, I will allow it until it is fixed.

@taiki-e
Copy link
Owner

taiki-e commented Apr 11, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 11, 2020

Build succeeded

@bors bors bot merged commit 389ce9d into taiki-e:master Apr 11, 2020
@Aaron1011 Aaron1011 deleted the fix/tuple-where-clause branch April 11, 2020 07:18
@taiki-e taiki-e added the A-pin-projection Area: #[pin_project] label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-pin-projection Area: #[pin_project]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aaron1011 @taiki-e