Do not expose unnamed projected types #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
added
A-pin-projection
|
This is not actually a breaking change as the generated unnamed projected types aren't public API. |
taiki-e
commented
Sep 7, 2020
Comment on lines
43
to
+47
| const _: () = { | ||
| #[allow(dead_code)] | ||
| #[allow(single_use_lifetimes)] | ||
| #[allow(clippy::type_repetition_in_bounds)] | ||
| enum __EnumProjectionRef<'pin, T, U> |
There was a problem hiding this comment.
This doesn't actually need to be generated, since we can't access the variant without naming it.
I'll optimize it in a later PR.
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Sep 10, 2020
270: Optimize code generation when used on enums r=taiki-e a=taiki-e When `#[pin_project]` is used on enums, only named projection types and methods are generated because there is no way to access variants of projected types without naming it. (When `#[pin_project]` is used on structs, both methods are always generated.) Addresses #268 (comment) Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot
added a commit
that referenced
this pull request
Sep 10, 2020
270: Optimize code generation when used on enums r=taiki-e a=taiki-e When `#[pin_project]` is used on enums, only named projection types and methods are generated because there is no way to access variants of projected types without naming it. (When `#[pin_project]` is used on structs, both methods are always generated.) Addresses #268 (comment) Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines projected types in inside
const _: () = {}when the users don't name it;cc #264