Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to syn-2 #352

Closed
wants to merge 1 commit into from
Closed

Update to syn-2 #352

wants to merge 1 commit into from

Conversation

maurer
Copy link
Contributor

@maurer maurer commented Apr 4, 2023

Effectively bumps MSRV to 1.56.0, due to syn-2 minimum requirements.

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pin-project-internal/Cargo.toml Outdated Show resolved Hide resolved
@@ -1,4 +1,4 @@
error: duplicate #[pin] attribute
error: expected attribute arguments in parentheses: `pin(...)`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but this diagnostic regression is a bit odd.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted the test to use an explicit #[pin] rather than your helper macro. Duplicate #[pin] still yields the correct error, it's a macro ordering issue that yields the must-have-argument issue.

Effectively bumps MSRV to 1.56.0, due to syn-2 minimum requirements.
@@ -4,9 +4,9 @@ use auxiliary_macro::add_pin_attr;
use pin_project::pin_project;

#[pin_project]
#[add_pin_attr(struct)] //~ ERROR duplicate #[pin] attribute
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, could you revert this change?

This file is about interaction with the other macros that edit the struct, and normal "duplicate #[pin] attribute" cases have already been tested in invalid.rs.

#[pin]
#[pin] //~ ERROR duplicate #[pin] attribute

(Given that the previous error was not actually ideal either, it is probably not a problem that the message here changes. The ideal one is line 13's "#[pin] attribute may only be used on ...")

Comment on lines 41 to 44
# For test on MSRV.
once_cell = "=1.14"
serde = "=1.0.156"
serde = "=1.0.159"
toml = "=0.5.9"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these lines (and line 39's trybuild's = requirement) can be removed because MSRV has increased.

@taiki-e
Copy link
Owner

taiki-e commented May 13, 2023

Merged as a part of #354. Thanks for your contribution!

@taiki-e taiki-e closed this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants