Add 'project_into' method to #[pin_project] types #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method consumes takes a 'Pin<&mut Self>' by value, instead of by mutable reference. This allows us to give the projection struct/enum a longer lifetime, which is required when returning it from a function Fixes taiki-e#65
taiki-e
approved these changes
Sep 4, 2019
taiki-e
force-pushed
the
feature/project_into
branch
from
3225597 to
e04660c
Compare
|
@Aaron1011 Thanks for all of your work on this! bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 4, 2019
69: Add 'project_into' method to #[pin_project] types r=taiki-e a=Aaron1011 This method consumes takes a 'Pin<&mut Self>' by value, instead of by mutable reference. This allows us to give the projection struct/enum a longer lifetime, which is required when returning it from a function Fixes #65 Co-authored-by: Aaron Hill <aa1ronham@gmail.com> Co-authored-by: Taiki Endo <te316e89@gmail.com>
Build succeeded
|
RalfJung
reviewed
Sep 11, 2019
| /// | ||
| /// ```ignore | ||
| /// fn project(&mut Pin<&mut Self>) -> ProjectedType; | ||
| /// fn project_into(Pin<&mut Self>) -> ProjectedType; |
There was a problem hiding this comment.
I think project should take Pin<&mut Self>, the double ptr-indirection looks very strange. The argument for why it has been added is incorrect I think, see what I wrote at #47 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method consumes takes a 'Pin<&mut Self>' by value, instead
of by mutable reference. This allows us to give the projection
struct/enum a longer lifetime, which is required when returning it
from a function
Fixes #65