Remove as _ casts

taiki-e · Apr 11, 2024 · 3c86e9c · 3c86e9c
1 parent dee1f89
commit 3c86e9c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/portable-atomic-util/src/arc.rs b/portable-atomic-util/src/arc.rs
@@ -522,7 +522,7 @@ impl<T> Arc<[mem::MaybeUninit<T>]> {
         let md_self = mem::ManuallyDrop::new(self);
         // SAFETY: [MaybeUninit<T>] has the same layout as [T], and
         // the caller must ensure data is initialized.
-        unsafe { Arc::from_ptr(md_self.ptr.as_ptr() as _) }
+        unsafe { Arc::from_ptr(md_self.ptr.as_ptr() as *mut ArcInner<[T]>) }
     }
 }
 

diff --git a/src/tests/helper.rs b/src/tests/helper.rs
@@ -1341,7 +1341,7 @@ macro_rules! __test_atomic_ptr {
             let x = &mut 1;
             for &order in &test_helper::SWAP_ORDERINGS {
                 assert_eq!(a.swap(x, order), ptr::null_mut());
-                assert_eq!(a.swap(ptr::null_mut(), order), x as _);
+                assert_eq!(a.swap(ptr::null_mut(), order), x as *mut _);
             }
         }
         #[test]
@@ -1357,12 +1357,12 @@ macro_rules! __test_atomic_ptr {
                     a.compare_exchange(ptr::null_mut(), x, success, failure),
                     Ok(ptr::null_mut()),
                 );
-                assert_eq!(a.load(Ordering::Relaxed), x as _);
+                assert_eq!(a.load(Ordering::Relaxed), x as *mut _);
                 assert_eq!(
                     a.compare_exchange(ptr::null_mut(), ptr::null_mut(), success, failure),
-                    Err(x as _),
+                    Err(x as *mut _),
                 );
-                assert_eq!(a.load(Ordering::Relaxed), x as _);
+                assert_eq!(a.load(Ordering::Relaxed), x as *mut _);
             }
         }
         #[test]
@@ -1382,7 +1382,7 @@ macro_rules! __test_atomic_ptr {
                         Err(x) => old = x,
                     }
                 }
-                assert_eq!(a.load(Ordering::Relaxed), x as _);
+                assert_eq!(a.load(Ordering::Relaxed), x as *mut _);
             }
         }
     };
@@ -2193,7 +2193,7 @@ macro_rules! __stress_test_acquire_release {
             s.spawn(|_| {
                 for i in 0..n {
                     b.store(i, Ordering::Relaxed);
-                    a.$write(i as _, Ordering::$store_order);
+                    a.$write(i as $int_type, Ordering::$store_order);
                 }
             });
             loop {

diff --git a/tests/api-test/src/helper.rs b/tests/api-test/src/helper.rs
@@ -740,7 +740,7 @@ macro_rules! __test_atomic_ptr {
             let x = &mut 1;
             for &order in &test_helper::SWAP_ORDERINGS {
                 assert_eq!(a.swap(x, order), core::ptr::null_mut());
-                assert_eq!(a.swap(core::ptr::null_mut(), order), x as _);
+                assert_eq!(a.swap(core::ptr::null_mut(), order), x as *mut _);
             }
         }
         __run_test!(compare_exchange);
@@ -752,17 +752,17 @@ macro_rules! __test_atomic_ptr {
                     a.compare_exchange(core::ptr::null_mut(), x, success, failure),
                     Ok(core::ptr::null_mut()),
                 );
-                assert_eq!(a.load(Ordering::Relaxed), x as _);
+                assert_eq!(a.load(Ordering::Relaxed), x as *mut _);
                 assert_eq!(
                     a.compare_exchange(
                         core::ptr::null_mut(),
                         core::ptr::null_mut(),
                         success,
                         failure
                     ),
-                    Err(x as _),
+                    Err(x as *mut _),
                 );
-                assert_eq!(a.load(Ordering::Relaxed), x as _);
+                assert_eq!(a.load(Ordering::Relaxed), x as *mut _);
             }
         }
         __run_test!(compare_exchange_weak);
@@ -781,7 +781,7 @@ macro_rules! __test_atomic_ptr {
                         Err(x) => old = x,
                     }
                 }
-                assert_eq!(a.load(Ordering::Relaxed), x as _);
+                assert_eq!(a.load(Ordering::Relaxed), x as *mut _);
             }
         }
         __run_test!(fetch_update);