Add #[inline] to fmt impls

rust-lang/rust#117727
taiki-e · Mar 15, 2024 · b623e70 · b623e70
1 parent 2b9c48a
commit b623e70
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -1406,15 +1406,15 @@ impl<T> From<*mut T> for AtomicPtr<T> {
 }
 
 impl<T> fmt::Debug for AtomicPtr<T> {
-    #[allow(clippy::missing_inline_in_public_items)] // fmt is not hot path
+    #[inline] // fmt is not hot path, but #[inline] on fmt seems to still be useful: https://github.com/rust-lang/rust/pull/117727
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         // std atomic types use Relaxed in Debug::fmt: https://github.com/rust-lang/rust/blob/1.70.0/library/core/src/sync/atomic.rs#L2024
         fmt::Debug::fmt(&self.load(Ordering::Relaxed), f)
     }
 }
 
 impl<T> fmt::Pointer for AtomicPtr<T> {
-    #[allow(clippy::missing_inline_in_public_items)] // fmt is not hot path
+    #[inline] // fmt is not hot path, but #[inline] on fmt seems to still be useful: https://github.com/rust-lang/rust/pull/117727
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         // std atomic types use Relaxed in Debug::fmt: https://github.com/rust-lang/rust/blob/1.70.0/library/core/src/sync/atomic.rs#L2024
         fmt::Pointer::fmt(&self.load(Ordering::Relaxed), f)

diff --git a/src/utils.rs b/src/utils.rs
@@ -130,7 +130,7 @@ macro_rules! const_fn {
 macro_rules! impl_debug_and_serde {
     ($atomic_type:ident) => {
         impl fmt::Debug for $atomic_type {
-            #[allow(clippy::missing_inline_in_public_items)] // fmt is not hot path
+            #[inline] // fmt is not hot path, but #[inline] on fmt seems to still be useful: https://github.com/rust-lang/rust/pull/117727
             fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
                 // std atomic types use Relaxed in Debug::fmt: https://github.com/rust-lang/rust/blob/1.70.0/library/core/src/sync/atomic.rs#L2024
                 fmt::Debug::fmt(&self.load(Ordering::Relaxed), f)