util: Add task::Wake #145
Merged
util: Add task::Wake #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
added
the
A-portable-atomic-util
notgull
approved these changes
Dec 28, 2023
|
Published in portable-atomic-util 0.2.0. |
notgull
pushed a commit
to smol-rs/waker-fn
that referenced
this pull request
May 9, 2024
portable-atomic-util now provides `std::task::Wake` equivalent: taiki-e/portable-atomic#145 This allows crates like waker-fn to support targets without atomics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an equivalent to
std::task::Wake, but usingportable_atomic_util::Arcas a reference-counted pointer.Note: Unlike
std::task::Wake, all methods takethis:instead ofself:. This is because usingportable_atomic_util::Arcas a receiver requires the unstablearbitrary_self_typesfeature.This should allow crates like waker-fn to support targets without atomics.
FYI @notgull