Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose sys::arm_compat::syscall as public API #7

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

t-moe
Copy link
Contributor

@t-moe t-moe commented Dec 22, 2023

Closes #6

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/sys/arm_compat/syscall/mod.rs Outdated Show resolved Hide resolved
src/sys/reg.rs Outdated Show resolved Hide resolved
src/sys/reg.rs Outdated Show resolved Hide resolved
src/sys/reg.rs Outdated Show resolved Hide resolved
src/sys/arm_compat/syscall/mod.rs Outdated Show resolved Hide resolved
src/sys/mips/syscall/mod.rs Outdated Show resolved Hide resolved
src/sys/arm_compat/syscall/mod.rs Outdated Show resolved Hide resolved
src/sys/mips/syscall/mod.rs Outdated Show resolved Hide resolved
@t-moe t-moe force-pushed the main branch 2 times, most recently from f81d7dc to 6ad3c82 Compare December 27, 2023 12:16
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from nits.

src/sys/mips/syscall/mips.rs Outdated Show resolved Hide resolved
src/sys/mips/syscall/mips.rs Outdated Show resolved Hide resolved
src/sys/mips/syscall/mips.rs Outdated Show resolved Hide resolved
src/sys/mips/syscall/mips.rs Outdated Show resolved Hide resolved
src/sys/mips/syscall/mod.rs Outdated Show resolved Hide resolved
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 603b3e5 into taiki-e:main Dec 27, 2023
14 checks passed
@t-moe
Copy link
Contributor Author

t-moe commented Dec 27, 2023

Oh, I forgot the changelog update.
Would you take a PR that updates the changelog and bumps the version, or do you prefer to do this yourself?

@taiki-e
Copy link
Owner

taiki-e commented Dec 27, 2023

Published in 0.1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support user defined semihosting operations
2 participants