Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more targets #2

Open
taiki-e opened this issue Feb 20, 2022 · 2 comments
Open

Support more targets #2

taiki-e opened this issue Feb 20, 2022 · 2 comments
Labels
C-enhancement Category: A new feature or an improvement for an existing one

Comments

@taiki-e
Copy link
Owner

taiki-e commented Feb 20, 2022

rust-cross-toolchain, on which this project is based, supports so many targets.

@taiki-e taiki-e added the C-enhancement Category: A new feature or an improvement for an existing one label Feb 20, 2022
@taiki-e taiki-e pinned this issue Feb 20, 2022
@zeeshanlakhani
Copy link
Contributor

zeeshanlakhani commented Jul 10, 2024

Hey @taiki-e,

I was going to add a PR to cargo-hack for it to build a release for illumos (x86_64-unknown-illumos). I see that rust-cross-toolchain already supports this, so it should be straightforward to update this action and easily run it for cargo-hack, right? I just wanted to ensure I wasn't missing something before doing the work.

Other options:

  • We can use cross directly in another job or via a conditional, but I'm guessing you'd prefer the toolchain set up already?

@taiki-e
Copy link
Owner Author

taiki-e commented Jul 12, 2024

I see that rust-cross-toolchain already supports this, so it should be straightforward to update this action and easily run it for cargo-hack, right?

Yeah, I guess it would generally be the same as the NetBSD case, except that it does not support multiple OS versions.

Probably could be implemented by simply adding an | *-illumos* to the two lines in main.sh, and updating the CI and readme.


*-freebsd* | *-netbsd*)

# NetBSD
# rustup target list | grep -e '-netbsd'
# rustc --print target-list | grep -e '-netbsd'
- target: aarch64-unknown-netbsd # tier3

zeeshanlakhani added a commit to zeeshanlakhani/setup-cross-toolchain-action that referenced this issue Jul 12, 2024
zeeshanlakhani added a commit to zeeshanlakhani/setup-cross-toolchain-action that referenced this issue Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A new feature or an improvement for an existing one
Projects
None yet
Development

No branches or pull requests

2 participants