Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update deprecated DisqusShortname usage in Whiteplain Hugo theme #34

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

robotAstray
Copy link
Contributor

Description

I have been using your theme to create a site with the Hugo site generator and noticed a small bug that needs attention. I have opened this PR to resolve this issue.

Steps to Reproduce

  1. Run the following command:

    hugo server --buildDraft

Error Message

```
ERROR deprecated: .Site.DisqusShortname was deprecated in Hugo v0.120.0 and will be removed in Hugo 0.134.0. Use .Site.Config.Services.Disqus.Shortname instead.
Built in 12 ms
Error: error building site: logged 1 error(s)
```

Software Version

  • Hugo v0.134.0

Proposed Solution

This PR updates the theme by replacing .Site.DisqusShortname with .Site.Config.Services.Disqus.Shortname in the layouts/_default/single.html file.

Revert back to `color: #444444;` from `color: #000000;`
Revert line 6 to `color: #444444;` in `style.css`
@robotAstray
Copy link
Contributor Author

@taikii I have reverted to color: #444444;on line 6

@taikii taikii merged commit e80918a into taikii:main Aug 31, 2024
@taikii
Copy link
Owner

taikii commented Aug 31, 2024

Thanks for the fix! I've merged this. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants