Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jwt secret for authentication #243

Merged
merged 4 commits into from
May 23, 2024
Merged

feat: add jwt secret for authentication #243

merged 4 commits into from
May 23, 2024

Conversation

johntaiko
Copy link
Contributor

@johntaiko johntaiko commented May 22, 2024

No description provided.

Copy link
Contributor

@smtmfft smtmfft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Also, I think the prove-block.sh needs update.
And maybe openAPI doc should take this into account, at lease when auth fails.

host/src/lib.rs Show resolved Hide resolved
@johntaiko johntaiko requested a review from smtmfft May 22, 2024 23:45
The code changes add a new field `jwt_secret` to the `Cli` struct in `lib.rs`. This field allows setting the JWT secret for authentication. Additionally, the `create_router` function in `api/mod.rs` now takes the `jwt_secret` as a parameter.

Recent user commits and repository commits are not relevant for generating the commit message.
@johntaiko johntaiko enabled auto-merge May 23, 2024 01:40
@johntaiko johntaiko changed the title feat: Add jwt secret for authentication feat: add jwt secret for authentication May 23, 2024
@johntaiko johntaiko added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 78a633d May 23, 2024
13 checks passed
@johntaiko johntaiko deleted the feat/jwt branch May 23, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants