Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(host): renew host tests #431

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Conversation

keroro520
Copy link
Contributor

@keroro520 keroro520 commented Dec 10, 2024

The previous integration tests have become outdated, and none of them are passing now.
This PR rewrites these outdated tests, and makes some refactors to make adding tests more easy.

@keroro520 keroro520 requested a review from smtmfft December 10, 2024 10:39
@keroro520 keroro520 force-pushed the renew-host-tests branch 2 times, most recently from 1367a3a to 5d236b6 Compare December 10, 2024 10:57
@keroro520 keroro520 requested a review from johntaiko December 12, 2024 13:12
Copy link
Contributor

@smtmfft smtmfft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
1 todo is config the CI yml to control the test scope.

host/tests/common/chain.rs Outdated Show resolved Hide resolved
host/tests/common/chain.rs Outdated Show resolved Hide resolved
host/tests/test/manual_test.rs Show resolved Hide resolved
@keroro520 keroro520 enabled auto-merge December 17, 2024 12:51
@keroro520 keroro520 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into taikoxyz:main with commit 40274d7 Dec 17, 2024
6 checks passed
@keroro520 keroro520 deleted the renew-host-tests branch December 17, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants