This repository has been archived by the owner on May 11, 2024. It is now read-only.
chore(prover): replace emoji in log message #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
approved these changes
Aug 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 51.71% 52.07% +0.36%
==========================================
Files 36 36
Lines 4438 4438
==========================================
+ Hits 2295 2311 +16
+ Misses 1880 1863 -17
- Partials 263 264 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Merged, thanks for the contribution! |
|
I heard that those whose pull requests are merged will receive a GitPOAP. Am I eligible? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request just replaces 🤷♂️ with 🤷 in the log messages.
Depending on the environment, 🤷♂️ is not displayed properly because it consists of 4 code points.
On iTerm2 on macOS, it is displayed as
🤷\u200d♂️.From the perspective of gender equality, it would be better to use the neutral one.