Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(prover): guardian prover block sign + bindings updates for based contestable zkrollup #450

Merged
merged 42 commits into from
Nov 25, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Nov 13, 2023

This pr catches up functionality for the next testnet, and adds a Guardian Prover Block Sign on onBlockProposed, to confirm accurate liveness of the guardian provers.

There is a hooks call in the taiko-mono like this:

   // prior to any code in this function has been executed.
            for (uint256 i; i < params.hookCalls.length; ++i) {
                // When a hook is called, all ether in this contract will be send to the hook.
                // If the ether sent to the hook is not used entirely, the hook shall send the Ether
                // back to this contract for the next hook to use.
                // Proposers shall choose use extra hooks wisely.
                IHook(params.hookCalls[i].hook).onBlockProposed{ value: address(this).balance }(
                    blk, meta, params.hookCalls[i].data
                );
            }

Because of this, DepositTaikoToken functionality has been removed from TaikoL1 contract, and thus, from this codebase. The AssignmentHook from taiko-mono has been implemented a default hook, always implemented, and a flag/etc to provide additional hooks has not been implemented.

I think it should be up to the communtiy to implement custom hooks, should they desire it, but we may want to add plugin functionality to allow people to create custom hooks easier in the future.

@cyberhorsey cyberhorsey requested review from davidtaikocha and RogerLamTd and removed request for davidtaikocha November 14, 2023 01:20
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (0ee8259) 60.71% compared to head (93839e9) 60.79%.

Files Patch % Lines
pkg/rpc/utils.go 0.00% 27 Missing ⚠️
prover/prover.go 40.54% 16 Missing and 6 partials ⚠️
proposer/proposer.go 60.00% 13 Missing and 3 partials ⚠️
prover/server/api.go 71.79% 8 Missing and 3 partials ⚠️
bindings/encoding/input.go 57.14% 2 Missing and 1 partial ⚠️
driver/state/state.go 0.00% 3 Missing ⚠️
proposer/prover_selector/eth_fee_eoa_selector.go 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   60.71%   60.79%   +0.07%     
==========================================
  Files          44       45       +1     
  Lines        5201     5338     +137     
==========================================
+ Hits         3158     3245      +87     
- Misses       1735     1772      +37     
- Partials      308      321      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyberhorsey cyberhorsey changed the title feat(prover): guardian prover block sign feat(prover): guardian prover block sign + bindings updates for based contestable zkrollup Nov 17, 2023
@davidtaikocha davidtaikocha merged commit 904d3e7 into main Nov 25, 2023
4 checks passed
@davidtaikocha davidtaikocha deleted the guardian_prover_block_sign branch November 25, 2023 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants