This repository has been archived by the owner on May 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 333
feat(prover): guardian prover block sign + bindings updates for based contestable zkrollup #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberhorsey
requested review from
davidtaikocha and
RogerLamTd
and removed request for
davidtaikocha
November 14, 2023 01:20
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 60.71% 60.79% +0.07%
==========================================
Files 44 45 +1
Lines 5201 5338 +137
==========================================
+ Hits 3158 3245 +87
- Misses 1735 1772 +37
- Partials 308 321 +13 ☔ View full report in Codecov by Sentry. |
…pi server, allow passing in through flag.
cyberhorsey
changed the title
feat(prover): guardian prover block sign
feat(prover): guardian prover block sign + bindings updates for based contestable zkrollup
Nov 17, 2023
RogerLamTd
approved these changes
Nov 18, 2023
davidtaikocha
approved these changes
Nov 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr catches up functionality for the next testnet, and adds a Guardian Prover Block Sign on
onBlockProposed
, to confirm accurate liveness of the guardian provers.There is a
hooks
call in thetaiko-mono
like this:Because of this,
DepositTaikoToken
functionality has been removed fromTaikoL1
contract, and thus, from this codebase. TheAssignmentHook
from taiko-mono has been implemented a default hook, always implemented, and a flag/etc to provide additional hooks has not been implemented.I think it should be up to the communtiy to implement custom hooks, should they desire it, but we may want to add plugin functionality to allow people to create custom hooks easier in the future.