Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(pkg): improve/simplify reorg check logic #647

Merged
merged 17 commits into from
Mar 22, 2024
Merged

Conversation

YoGhurt111
Copy link
Contributor

CHANGELOG #600

  1. Find a better L1 height to reset rather than the genesis height when there is a mismatch between protocol and L2 EE

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 54.87805% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 50.32%. Comparing base (9ac73ba) to head (392b570).

❗ Current head 392b570 differs from pull request most recent head 0a1e4a0. Consider uploading reports for the commit 0a1e4a0 to get more accurate results

Files Patch % Lines
driver/chain_syncer/calldata/syncer.go 53.16% 31 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
+ Coverage   50.15%   50.32%   +0.16%     
==========================================
  Files          58       58              
  Lines        6003     6057      +54     
==========================================
+ Hits         3011     3048      +37     
- Misses       2666     2678      +12     
- Partials      326      331       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidtaikocha davidtaikocha linked an issue Mar 19, 2024 that may be closed by this pull request
driver/chain_syncer/calldata/syncer.go Outdated Show resolved Hide resolved
driver/chain_syncer/calldata/syncer.go Outdated Show resolved Hide resolved
@mask-pp mask-pp marked this pull request as ready for review March 19, 2024 08:37
YoGhurt111 and others added 2 commits March 19, 2024 17:02
Co-authored-by: maskpp <maskpp266@gmail.com>
Co-authored-by: maskpp <maskpp266@gmail.com>
cmd/flags/driver.go Show resolved Hide resolved
driver/chain_syncer/calldata/syncer.go Outdated Show resolved Hide resolved
driver/chain_syncer/calldata/syncer.go Outdated Show resolved Hide resolved
driver/chain_syncer/calldata/syncer.go Outdated Show resolved Hide resolved
driver/chain_syncer/calldata/syncer.go Outdated Show resolved Hide resolved
driver/chain_syncer/calldata/syncer.go Outdated Show resolved Hide resolved
driver/chain_syncer/calldata/syncer.go Outdated Show resolved Hide resolved
@davidtaikocha davidtaikocha enabled auto-merge (squash) March 22, 2024 11:56
@davidtaikocha davidtaikocha merged commit 0b08772 into main Mar 22, 2024
4 checks passed
@davidtaikocha davidtaikocha deleted the improve-reorg-check branch March 22, 2024 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(pkg): improve/simplify reorg check logic
3 participants