-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): update LibBlockHeader
to hash post Shanghai fork blocks
#13278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it and worked for me.
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## main #13278 +/- ##
==========================================
- Coverage 61.61% 61.54% -0.08%
==========================================
Files 118 118
Lines 3478 3482 +4
Branches 491 493 +2
==========================================
Hits 2143 2143
- Misses 1250 1255 +5
+ Partials 85 84 -1
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Since Sepolia has already activated Shanghai hard fork, we need to update the block hash calculation in
LibBlockHeader
to ensureHeaderSyncer
can still work as expected. Will dig into EIP-4895 later to see how it works in go-ethereum.