docs(protocol): fix LibBlockHeader comment on EIP-1559 #13276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #13276 +/- ##
==========================================
- Coverage 61.61% 61.50% -0.12%
==========================================
Files 118 118
Lines 3478 3478
Branches 491 491
==========================================
- Hits 2143 2139 -4
- Misses 1250 1255 +5
+ Partials 85 84 -1
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
previously approved these changes
Mar 9, 2023
| list = new bytes[](15 + extraCapacity); | ||
| } else { | ||
| // EIP1159 transaction | ||
| // EIP-1159 transaction |
| @@ -69,7 +69,7 @@ library LibBlockHeader { | |||
| // as [8]byte when hashing the block. | |||
| list[14] = LibRLPWriter.writeBytes(abi.encodePacked(header.nonce)); | |||
| if (header.baseFeePerGas != 0) { | |||
| // non-EIP11559 transaction | |||
| // EIP-1159 transaction | |||
Co-authored-by: David <david@taiko.xyz>
dantaik
approved these changes
Mar 9, 2023
|
@davidtaikocha could you resolve this? |
i believe all the changes in this pr have already been covered by #13278, so we can safely close this one? |
|
Ok, lets close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.