-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): step 3 - enhance ZKP handling & change proofs order #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dantaik
requested review from
davidtaikocha,
Brechtpd,
cyberhorsey and
dionysuzx
November 18, 2022 09:27
Codecov Report
@@ Coverage Diff @@
## main #288 +/- ##
==========================================
- Coverage 63.81% 62.83% -0.99%
==========================================
Files 81 82 +1
Lines 2388 2416 +28
Branches 270 281 +11
==========================================
- Hits 1524 1518 -6
- Misses 795 830 +35
+ Partials 69 68 -1
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
previously approved these changes
Nov 19, 2022
dantaik
changed the title
feat(protocol): suspend the chain if we have two conflicting ZKPs
feat(protocol): enhanced ZKP handling
Nov 19, 2022
dantaik
changed the title
feat(protocol): enhanced ZKP handling
feat(protocol): enhance ZKP handling
Nov 19, 2022
dantaik
changed the base branch from
disable-codecov-project-patch
to
finalize_to_verify
November 20, 2022 06:49
dantaik
changed the title
feat(protocol): enhance ZKP handling & change proofs order
feat(protocol): step 3 - enhance ZKP handling & change proofs order
Nov 20, 2022
Brechtpd
previously approved these changes
Nov 21, 2022
davidtaikocha
previously approved these changes
Nov 22, 2022
davidtaikocha
approved these changes
Nov 22, 2022
Brechtpd
approved these changes
Nov 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidtaikocha notice the order of proofs in evidence has changed.