Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): step 3 - enhance ZKP handling & change proofs order #288

Merged
merged 44 commits into from
Nov 22, 2022

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Nov 18, 2022

  • If two ZKPs claims different block header based on the same parent, then there must be a bug with our circuits. The chain then automatically halts
  • Allow more than one ZK prover per block

@davidtaikocha notice the order of proofs in evidence has changed.

@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
website ⬜️ Ignored (Inspect) Nov 19, 2022 at 2:28AM (UTC)

@dantaik dantaik marked this pull request as ready for review November 18, 2022 09:29
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #288 (07ae4f0) into main (5c4d370) will decrease coverage by 0.98%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   63.81%   62.83%   -0.99%     
==========================================
  Files          81       82       +1     
  Lines        2388     2416      +28     
  Branches      270      281      +11     
==========================================
- Hits         1524     1518       -6     
- Misses        795      830      +35     
+ Partials       69       68       -1     
Flag Coverage Δ *Carryforward flag
protocol 58.57% <0.00%> (-1.51%) ⬇️
relayer 68.57% <ø> (-0.20%) ⬇️ Carriedforward from 4413541

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/LibData.sol 21.42% <ø> (ø)
packages/protocol/contracts/L1/TaikoL1.sol 17.77% <0.00%> (-1.74%) ⬇️
packages/protocol/contracts/L1/v1/V1Finalizing.sol 18.18% <0.00%> (-4.90%) ⬇️
packages/protocol/contracts/L1/v1/V1Proposing.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Proving.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Utils.sol 0.00% <0.00%> (ø)
...ol/contracts/test/thirdparty/TestMessageSender.sol 100.00% <ø> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (-7.23%) ⬇️
packages/relayer/http/server.go 94.02% <0.00%> (-2.99%) ⬇️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cyberhorsey
cyberhorsey previously approved these changes Nov 19, 2022
@dantaik dantaik changed the title feat(protocol): suspend the chain if we have two conflicting ZKPs feat(protocol): enhanced ZKP handling Nov 19, 2022
@dantaik dantaik changed the title feat(protocol): enhanced ZKP handling feat(protocol): enhance ZKP handling Nov 19, 2022
@dantaik dantaik changed the base branch from disable-codecov-project-patch to finalize_to_verify November 20, 2022 06:49
@dantaik dantaik changed the title feat(protocol): enhance ZKP handling & change proofs order feat(protocol): step 3 - enhance ZKP handling & change proofs order Nov 20, 2022
Brechtpd
Brechtpd previously approved these changes Nov 21, 2022
Base automatically changed from finalize_to_verify to main November 22, 2022 02:21
@dantaik dantaik enabled auto-merge (squash) November 22, 2022 02:23
davidtaikocha
davidtaikocha previously approved these changes Nov 22, 2022
@dantaik dantaik enabled auto-merge (squash) November 22, 2022 11:22
@dantaik dantaik merged commit 5fdfdfa into main Nov 22, 2022
@dantaik dantaik deleted the security1 branch November 22, 2022 15:18
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[protocol] enable more than one circuits to have multiple proofs per block
4 participants