-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(relayer): Withdrawals root #13360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion.svelte, use fromchainid and tochainid
…ist whe nwe are trying to use it to lookup and set tx.msgHash...
Codecov Report
@@ Coverage Diff @@
## alpha-2 #13360 +/- ##
==========================================
Coverage ? 35.15%
==========================================
Files ? 122
Lines ? 3689
Branches ? 510
==========================================
Hits ? 1297
Misses ? 2302
Partials ? 90
*This pull request uses carry forward flags. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
requested review from
jscriptcoder,
shadab-taiko,
davidtaikocha,
adaki2004 and
dantaik
and removed request for
jscriptcoder
March 18, 2023 19:40
davidtaikocha
approved these changes
Mar 19, 2023
dantaik
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the remaining bridge issues for claiming messages.
post-shanghai forks need withdrawalsRoot for generating proofs. This is why neither relayer nor bridge-ui work on Sepolia right now, but work on internal devnet, hardhat tests, and Goerli. But code must be backwards compatible with non-shanghai chains. Now this proof generation works on both.
Ethers can not process empty string for
bytes
orbytes32
, so with relayer-saved transactions from the API, we need to check ifMessage.Data
is empty, and if so, set it to0x
, which ethers accepts.Working in this project doesnt feel good with adding very strict
eslint
and then not fixing any of the issues. I removed ESLint, and we can re-add a light one, and fix rules one by one, so its a happy working environment. There is no value to the current approach at all.Update
go-ethereum
library to latest, so we have access toWithdrawalsHash
on the header, for post-Shanghai forks such as Sepolia.Add code coverage for both types of blocks.
bridge UI was using the MySQL database ID and not the message ID, so claim header hash would not be valid.
After merging this,
bridge-ui
will auto deploy to Vercel, butrelayer
needs deployment in Kubernetes after latest image builds.