-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol): various changes based on Brecht & Dani's feedback #13427
Conversation
Codecov Report
@@ Coverage Diff @@
## major_protocol_upgrade_rebase #13427 +/- ##
=================================================================
- Coverage 40.07% 39.81% -0.26%
=================================================================
Files 112 112
Lines 3404 3403 -1
Branches 413 405 -8
=================================================================
- Hits 1364 1355 -9
- Misses 1952 1960 +8
Partials 88 88
*This pull request uses carry forward flags. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
uint256 fcId = state.forkChoiceIds[id][parentHash]; | ||
if (blk.blockId != blockId) revert L1_BLOCK_ID(); | ||
|
||
uint256 fcId = state.forkChoiceIds[blockId][parentHash]; | ||
if (fcId == 0 || fcId >= blk.nextForkChoiceId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it as above, dont know in which scenario it could happen.
If fcId == 0
, then blk.nextForkChoiceId == 1
-> No proof submitted.
If blk.nextForkChoiceId == 2
a proof is submitted either by an oracle or single prover, but in such case the second proof submitted (when unverified) does not increase blk.nextForkChoiceId
above 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fcId==0
means the fork choice does not existfcId >= blk.nextForkChoiceId
shall never happen. I convert it into anassert
Previously
Now