-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol): change TaikoToken's decimals from 18 to 8 #13443
refactor(protocol): change TaikoToken's decimals from 18 to 8 #13443
Conversation
Codecov Report
@@ Coverage Diff @@
## major_protocol_upgrade_rebase #13443 +/- ##
=================================================================
+ Coverage 39.18% 40.18% +1.00%
=================================================================
Files 111 112 +1
Lines 3366 3394 +28
Branches 382 411 +29
=================================================================
+ Hits 1319 1364 +45
+ Misses 1959 1942 -17
Partials 88 88
*This pull request uses carry forward flags. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The main objective for such a change is to make sure the current and future max supply can fit in to a
uint64
so the protocol code can use one singleuint64
to hold any taiko token amount.type(uint64).max/ (10**18) = 184,467,440,737 which is 184 billion. I don't think our max supply will ever be 10 billion.