refactor(protocol): split oracle proving into a function #13552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## major_protocol_upgrade_rebase #13552 +/- ##
=================================================================
- Coverage 39.21% 38.85% -0.36%
=================================================================
Files 113 113
Lines 3445 3464 +19
Branches 392 399 +7
=================================================================
- Hits 1351 1346 -5
- Misses 2005 2029 +24
Partials 89 89
*This pull request uses carry forward flags. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Brechtpd
approved these changes
Apr 6, 2023
| state.forkChoiceIds[id][oracle.parentHash] = fcId; | ||
| } else { | ||
| fc = blk.forkChoices[fcId]; | ||
| if (fc.prover != address(0)) revert L1_ALREADY_PROVEN(); |
There was a problem hiding this comment.
Maybe still allow overwriting even when already proven by another prover? Only possible when ZKPs are incomplete/buggy, but we're likely to need something that'll allow us to do this somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the oracle prover to batch-prove multiple blocks in one L1 transaction to save cost. These are the following benefits: