Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): optimize keyForName #13557

Merged
merged 17 commits into from
Apr 6, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 6, 2023

Previously

Function Name min avg median max # calls
keyForName 2232 2323 2377 2377 40
proposeBlock 22385 32506 22405 92404 309
proveBlock 55304 65358 55304 131704 309
resolve(string,bool)(address) 4407 4490 4407 10907 629
resolve(uint256,string,bool)(address) 4310 4342 4310 6310 927
verifyBlocks 13575 14588 14293 80372 301

Now

Function Name min avg median max # calls
keyForName 1459 1459 1459 1459 40
proposeBlock 21688 31809 21708 91707 309
proveBlock 52241 62295 52241 128641 309
resolve(string,bool)(address) 3571 3654 3571 10071 629
resolve(uint256,string,bool)(address) 3613 3646 3613 5616 927
verifyBlocks 13575 14588 14293 80372 301

Copy link
Contributor

@adaki2004 adaki2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be sure that off-chain (tests or BE/FE client side typescript) we reconstruct it the same way.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (major_protocol_upgrade_rebase@15523af). Click here to learn what that means.
The diff coverage is n/a.

@@                       Coverage Diff                        @@
##             major_protocol_upgrade_rebase   #13557   +/-   ##
================================================================
  Coverage                                 ?   39.15%           
================================================================
  Files                                    ?      113           
  Lines                                    ?     3445           
  Branches                                 ?      392           
================================================================
  Hits                                     ?     1349           
  Misses                                   ?     2007           
  Partials                                 ?       89           
Flag Coverage Δ *Carryforward flag
bridge-ui 94.20% <0.00%> (?) Carriedforward from 0509218
eventindexer ∅ <0.00%> (?) Carriedforward from 0509218
protocol 0.00% <0.00%> (?)
relayer 62.42% <0.00%> (?) Carriedforward from 0509218
ui 100.00% <0.00%> (?) Carriedforward from 0509218

*This pull request uses carry forward flags. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik merged commit 2bad518 into major_protocol_upgrade_rebase Apr 6, 2023
@dantaik dantaik deleted the resolve_address_improve branch April 6, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: optimize keyForName method in AddressResolver.sol
3 participants