feat(protocol): allow multiple Taiko deployments to sync signals #13565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## major_protocol_upgrade_rebase #13565 +/- ##
=================================================================
- Coverage 38.82% 38.79% -0.03%
=================================================================
Files 113 113
Lines 3480 3482 +2
Branches 400 401 +1
=================================================================
Hits 1351 1351
- Misses 2040 2042 +2
Partials 89 89
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
requested review from
Brechtpd,
cyberhorsey and
davidtaikocha
and removed request for
Brechtpd
Brechtpd
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine two Taiko layer 3s (Taiko-L3A and Taiko-L3B) are deployed on a Taiko-L2 and the layer 3s share the same SignalService instance on L2. The demand to transfer funds (or send signals in general) across these layer 3s will be common.
This change makes sure when Taiko-L3A's signalRoot is sent over to L2, the L2 contract will relay the signalRoot to the shared SignalService as a signal, then when Taiko-L3B gets the L2's signalRoot, that signalRoot carries info about Taiko-L3A's signalRoot. Verifying the signal on Taiko-L3B will require two (partial) Merkle proofs.
This change will increase
verifyBlocks's gas cost from 14086 to 41325, that's because we always write to new signal slots. But since this feature will only be turned for Taiko layer 3 deployments (their TaikoL1.sol contracts will be on Taiko L2), the extra gas cost shall be fine.