test(protocol): Signal service foundry tests #13632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est,. write signalservice foundry tests.
|
@cyberhorsey There are testing failures. |
Please read the main comment of this PR |
|
Lets delete them. |
Done, plus I changed the package.json commands, and Github Actions. |
Codecov Report
@@ Coverage Diff @@
## major_protocol_upgrade_rebase #13632 +/- ##
================================================================
Coverage ? 46.25%
================================================================
Files ? 123
Lines ? 3524
Branches ? 313
================================================================
Hits ? 1630
Misses ? 1779
Partials ? 115
*This pull request uses carry forward flags. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
changed the base branch from
major_protocol_upgrade_rebase
to
opimize_proving
Base automatically changed from
opimize_proving
to
major_protocol_upgrade_rebase
April 23, 2023 10:31
dantaik
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
major_protocol_upgrade_rebasebranch had a.onlyon a SignalService test, so the tests werent actually running. Only a single test was. Now that I've deleted that test, this shows that 6 of them are now failing, but they were always failing on your branch @dantaik , just hidden.
Should we just scrap the hardhat tests, or add another
.onlyso they "appear" to pass? I'm in favor of just deleting them all rather than putting it any work to make them pass.