Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): improve on top of Dani's PR #13635

Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 22, 2023

No logical changes, purely refactoring for better maintainability.

dantaik added 3 commits April 22, 2023 15:08

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@dantaik dantaik requested a review from adaki2004 April 22, 2023 07:37
@dantaik dantaik marked this pull request as ready for review April 22, 2023 07:38
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #13635 (e4d2db7) into prove_time_based_rewards_exp (519dca7) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@                       Coverage Diff                        @@
##           prove_time_based_rewards_exp   #13635      +/-   ##
================================================================
+ Coverage                         39.28%   39.36%   +0.08%     
================================================================
  Files                               113      113              
  Lines                              3439     3432       -7     
  Branches                            404      402       -2     
================================================================
  Hits                               1351     1351              
+ Misses                             1999     1992       -7     
  Partials                             89       89              
Flag Coverage Δ *Carryforward flag
bridge-ui 94.20% <ø> (ø) Carriedforward from d196500
eventindexer ∅ <ø> (∅) Carriedforward from d196500
protocol 0.00% <0.00%> (ø)
relayer 62.55% <ø> (ø) Carriedforward from d196500
ui 100.00% <ø> (ø) Carriedforward from d196500

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 0.00% <0.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <ø> (ø)
...kages/protocol/contracts/L1/libs/LibTokenomics.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/libs/LibUtils.sol 0.00% <0.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik self-assigned this Apr 22, 2023
@adaki2004 adaki2004 merged commit 7537cd1 into prove_time_based_rewards_exp Apr 22, 2023
@adaki2004 adaki2004 deleted the prove_time_based_rewards_exp_improve branch April 22, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants