Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): additional cleaning up #13646

Merged
merged 6 commits into from
Apr 25, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 25, 2023

No description provided.

@dantaik dantaik changed the base branch from main to major_protocol_upgrade_alpha3 April 25, 2023 10:22
@dantaik dantaik marked this pull request as ready for review April 25, 2023 10:22
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #13646 (eb2cc41) into major_protocol_upgrade_alpha3 (8ebd2ce) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head eb2cc41 differs from pull request most recent head 64ff19c. Consider uploading reports for the commit 64ff19c to get more accurate results

@@                        Coverage Diff                        @@
##           major_protocol_upgrade_alpha3   #13646      +/-   ##
=================================================================
+ Coverage                          44.76%   44.82%   +0.05%     
=================================================================
  Files                                132      132              
  Lines                               3527     3527              
  Branches                             361      361              
=================================================================
+ Hits                                1579     1581       +2     
+ Misses                              1847     1845       -2     
  Partials                             101      101              
Flag Coverage Δ *Carryforward flag
bridge-ui 95.80% <ø> (ø)
eventindexer 82.08% <ø> (+0.99%) ⬆️
protocol 0.00% <ø> (ø) Carriedforward from 38497a5
relayer 62.42% <ø> (ø) Carriedforward from 38497a5
ui 100.00% <ø> (ø) Carriedforward from 38497a5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 0.00% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/libs/LibUtils.sol 0.00% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 0.00% <ø> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik merged commit a1fc8b1 into major_protocol_upgrade_alpha3 Apr 25, 2023
@dantaik dantaik deleted the eip1559_improve branch April 25, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📝 Todo
Development

Successfully merging this pull request may close these issues.

1 participant